fedserv/echo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Gate OperServ EXCEPTION at admin tier and reject match-all SNLINE regex

Browse source
This commit is contained in:
Jean Chevronnet 2026-07-19 13:17:54 +00:00
parent e7f012726c
commit 7528b78bf7
No known key found for this signature in database
2 changed files with 7 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
modules/operserv/src/session.rs
View file

@ -33,7 +33,7 @@ pub fn handle_session(me: &str, from: &Sender, args: &[&str], ctx: &mut ServiceC
}
pub fn handle_exception(me: &str, from: &Sender, args: &[&str], ctx: &mut ServiceCtx, db: &mut dyn Store) {
if !from.privs.has(Priv::Oper) {
if !from.privs.has(Priv::Admin) {
ctx.notice(me, from.uid, "Access denied — EXCEPTION needs the \x02admin\x02 privilege.");
return;
}

9
modules/operserv/src/xline.rs
View file

@ -44,7 +44,7 @@ impl Xline {
ctx.notice(me, from.uid, "Please give a reason.");
return;
}
if too_wide(&mask) {
if too_wide(&mask, self.kind == XlineKind::Rline) {
ctx.notice(me, from.uid, "That mask is too wide — it would match almost everyone.");
return;
}
@ -169,9 +169,12 @@ fn norm_channel(input: &str) -> Option<String> {
// A mask whose every meaningful character is a wildcard would match nearly all.
// A leading channel prefix is ignored so `#*` counts as too wide.
fn too_wide(mask: &str) -> bool {
fn too_wide(mask: &str, is_regex: bool) -> bool {
let body = mask.strip_prefix('#').or_else(|| mask.strip_prefix('&')).unwrap_or(mask);
body.is_empty() || body.chars().all(|c| c == '*' || c == '?' || c == '.' || c == '@')
// A realname REGEX that's a bare quantifier over any-char (.+ / .* / .) matches
// everyone, so treat '+' as a wildcard too — otherwise `SNLINE ADD .+` bans the
// whole network (glob '*'/'?' and '.' are already caught).
body.is_empty() || body.chars().all(|c| c == '*' || c == '?' || c == '.' || c == '@' || (is_regex && c == '+'))
}
fn human_secs(secs: u64) -> String {