fedserv/echoIRCd
1
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

s2s/xline: reject a malformed ADDLINE duration instead of coercing it to 0 (= a silent permanent ban), and make add_xline expiry saturating (n.saturating_add) so a peer sending duration=u64::MAX can't overflow-panic the debug build or wrap in release

Browse source
This commit is contained in:
Jean Chevronnet 2026-08-19 00:39:40 +00:00
parent bbe4ee4567
commit 11cec9fc36
2 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/link.rs
View file

@ -1361,7 +1361,12 @@ impl Server {
let Some(kind) = crate::xline::XKind::from_tag(&msg.params[0]) else {
return;
};
let duration: u64 = msg.params[4].parse().unwrap_or(0);
// A malformed duration must not be silently coerced to 0 (= permanent);
// a legitimate peer always sends a decimal integer (0 explicitly means
// permanent). Reject garbage rather than installing an accidental perma-ban.
let Ok(duration) = msg.params[4].parse::<u64>() else {
return;
};
self.add_xline(kind, &msg.params[1], duration, &msg.params[2], &msg.params[5]);
self.propagate(&msg.to_wire(), Some(via));
}