fedserv/echoIRCd
1
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

server: scrub a departed user's pending invites via a User.invited reverse index instead of scanning every channel on the network per quit — the old O(channels)-per-quit path was O(channels*quits) on a netsplit; the index is maintained at the 4 invite add/remove sites (INVITE cmd, S2S INVITE, join-consume, UNINVITE)

Browse source
This commit is contained in:
Jean Chevronnet 2026-08-19 02:09:36 +00:00
parent 5101b1361d
commit ab0ccae71f
7 changed files with 23 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/server.rs
View file

@ -373,6 +373,7 @@ impl Server {
caps: Caps::default(),
sasl_mech: None,
channels: HashSet::default(),
invited: HashSet::default(),
watch: Vec::new(),
monitor: Vec::new(),
silence: Vec::new(),
@ -724,8 +725,12 @@ impl Server {
// Scrub any pending +i invite for this user from channels they never joined
// (a member consumes their invite on join; a never-joined invite for a now-
// departed uid would otherwise linger forever on a persistent channel).
for ch in self.channels.values_mut() {
ch.invites.remove(&uid);
// The `invited` reverse index gives the exact channels, so this is O(pending
// invites) rather than a scan of every channel on the network.
for key in &user.invited {
if let Some(ch) = self.channels.get_mut(key) {
ch.invites.remove(&uid);
}
}
self.channels.retain(|_, c| c.keep_alive());
self.watch_notify_offline(&user.nick); // tell WATCH/MONITOR watchers
@ -1424,6 +1429,7 @@ mod tests {
caps: Caps::default(),
sasl_mech: None,
channels: HashSet::default(),
invited: HashSet::default(),
watch: Vec::new(),
monitor: Vec::new(),
silence: Vec::new(),