fedserv/echoIRCd
1
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

metrics: set read/write timeouts on each scrape connection — the single-threaded accept loop did an untimed read, so one client that connected and never sent blocked every future scrape (slowloris)

Browse source
This commit is contained in:
Jean Chevronnet 2026-08-19 01:21:21 +00:00
parent ac3e66e9e0
commit b63458816e
1 changed files with 5 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/modules/metrics.rs
View file

@ -75,6 +75,11 @@ pub fn maybe_start(cfg: &Config) {
fn serve(listener: TcpListener, metrics: Arc<Metrics>) { fn serve(listener: TcpListener, metrics: Arc<Metrics>) {
for stream in listener.incoming() { for stream in listener.incoming() {
let Ok(mut s) = stream else { continue }; let Ok(mut s) = stream else { continue };
// Bound how long one (possibly slow/hostile) client can hold this
// single-threaded scrape loop — without a timeout a client that connects
// and never sends would block every future scrape (slowloris).
let _ = s.set_read_timeout(Some(std::time::Duration::from_secs(5)));
let _ = s.set_write_timeout(Some(std::time::Duration::from_secs(5)));
// read (and ignore) the request head, then reply — this is a scrape, no routing // read (and ignore) the request head, then reply — this is a scrape, no routing
let mut buf = [0u8; 1024]; let mut buf = [0u8; 1024];
let _ = s.read(&mut buf); let _ = s.read(&mut buf);