fedserv/echoIRCd
1
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

webirc: require a non-empty source-IP mask on a webirc block — an empty ipmask meant "any IP", so a maskless webirc=<password> block turned one shared secret into a full host/IP spoof (bypassing z-lines, DNSBL, GeoIP, cloak) for anyone who learned it; now the gateway's connecting IP must match the block's ipmask

Browse source
This commit is contained in:
Jean Chevronnet 2026-08-19 00:34:25 +00:00
parent f56b68d6f5
commit c99f16f3e0
1 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/coremods/core_user.rs
View file

@ -75,8 +75,10 @@ impl Command for Vhost {
/// WEBIRC — a trusted web gateway declares the real client's host + IP, so users /// WEBIRC — a trusted web gateway declares the real client's host + IP, so users
/// behind it don't all share the gateway's address. `WEBIRC <password> <gateway> /// behind it don't all share the gateway's address. `WEBIRC <password> <gateway>
/// <hostname> <ip> [:flags]`; must precede registration and the password must /// <hostname> <ip> [:flags]`; must precede registration and the password must
/// match a `webirc` config block. (Password-only trust for now — restricting it /// match a `webirc` config block whose `ipmask` also matches the gateway's own
/// to the gateway's own source IP is a TODO.) /// connecting IP. A block with no `ipmask` is rejected: a shared password alone
/// would let anyone who learns it spoof any host/IP (bypassing z-lines, DNSBL,
/// GeoIP and cloaking).
struct WebIrc; struct WebIrc;
impl Command for WebIrc { impl Command for WebIrc {
fn name(&self) -> &'static str { fn name(&self) -> &'static str {
@ -102,7 +104,7 @@ impl Command for WebIrc {
let Some(gw) = s let Some(gw) = s
.webirc .webirc
.iter() .iter()
.find(|g| g.password == *pass && (g.ipmask.is_empty() || glob_match(&g.ipmask, &from))) .find(|g| g.password == *pass && !g.ipmask.is_empty() && glob_match(&g.ipmask, &from))
.map(|g| g.name.clone()) .map(|g| g.name.clone())
else { else {
s.notice_star(uid, "WEBIRC: invalid credentials"); s.notice_star(uid, "WEBIRC: invalid credentials");