orbit/orbit
orbit/orbit
0
0
Fork 0
Code Issues 3 Pull requests 5 Projects Releases Packages Wiki Activity Actions

console: run app commands from the status window, not just raw

Browse source 
The status/console window short-circuited every line to a raw IRC send, so app
commands typed there silently failed: /whois's reply was captured for the panel but
nothing showed it, /msg became an invalid MSG line, /list and /ignore did nothing.

Now only a bare line (no slash) is a raw IRC command there; slash-commands fall
through to the normal dispatch so /whois (prints inline in yomirc, panel otherwise),
/msg, /join (joins + switches), /nick, /list, /ignore all work from the console.
Channel commands run from the console (/part /topic /kick, /whois with no arg whois
yourself) go raw with the #chan you pass, their reply landing back in the console;
raw passthrough still echoes the line.
This commit is contained in:
Jean Chevronnet 2026-07-05 03:47:18 +00:00
parent 9222a315e5
commit ab1bcfeffb
No known key found for this signature in database
1 changed files with 25 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

35
src/core/store.ts
View file

@ -430,10 +430,14 @@ export function createChatStore(ns = '') {
// the leading '/' and send the command as a plain (formatted) message.
const cmdline = stripFormatting(text).trimStart();
// The Console buffer is a raw IRC command line (leading '/' optional).
if (active === SERVER) {
const raw = cmdline.startsWith('/') ? cmdline.slice(1) : cmdline;
if (!raw.trim()) return;
// The Console: a bare line (no leading slash) is a raw IRC command line — the
// classic mIRC status-window convenience. Slash-commands fall through to the
// normal dispatch below so /whois, /msg, /join … actually behave (raw-sending
// them would swallow /whois's reply and mangle /msg into an invalid command);
// channel commands run from here have no active channel so they go raw too.
if (active === SERVER && !cmdline.startsWith('/')) {
const raw = cmdline.trim();
if (!raw) return;
sysLine(SERVER, `» ${raw}`, 'system');
client.send(raw);
return;
@ -442,13 +446,24 @@ export function createChatStore(ns = '') {
if (cmdline.startsWith('/')) {
const [cmd, ...rest] = cmdline.slice(1).split(' ');
const arg = rest.join(' ');
// From the Console there's no active channel to act on: a channel command
// (the user supplies #chan in the args, e.g. /kick #c nick) is sent raw and
// its reply returns here. Returns true when it handled the line.
const rawFromConsole = (): boolean => {
if (active !== SERVER) return false;
const raw = cmdline.slice(1);
sysLine(SERVER, `» ${raw}`, 'system');
client.send(raw);
return true;
};
switch (cmd.toLowerCase()) {
case 'me': client.action(active, arg); break;
case 'me': if (active !== SERVER) client.action(active, arg); break;
case 'join': client.join(arg); get().setActive(arg.split(' ')[0]); break;
case 'part': client.part(active); break;
case 'part': if (!rawFromConsole()) client.part(active); break;
case 'nick': client.setNick(arg); break;
case 'whois': {
const who = arg.trim().split(' ')[0] || active;
const who = arg.trim().split(' ')[0] || (active === SERVER ? get().nick : active);
if (!who) break;
// yomirc mimics classic mIRC: print WHOIS to the active window as text.
if (getTheme().startsWith('yomirc')) get().whoisText(who); else get().openUser(who);
break;
@ -484,8 +499,8 @@ export function createChatStore(ns = '') {
}
break;
}
case 'topic': if (isChannelName(active)) client.setTopic(active, arg); break;
case 'kick': { const [t, ...r] = rest; if (isChannelName(active) && t) client.kick(active, t, r.join(' ')); break; }
case 'topic': if (!rawFromConsole() && isChannelName(active)) client.setTopic(active, arg); break;
case 'kick': { if (rawFromConsole()) break; const [t, ...r] = rest; if (isChannelName(active) && t) client.kick(active, t, r.join(' ')); break; }
case 'op': if (isChannelName(active) && arg) client.setUserMode(active, 'o', true, arg.trim()); break;
case 'deop': if (isChannelName(active) && arg) client.setUserMode(active, 'o', false, arg.trim()); break;
case 'voice': if (isChannelName(active) && arg) client.setUserMode(active, 'v', true, arg.trim()); break;
@ -495,7 +510,7 @@ export function createChatStore(ns = '') {
default: {
const pc = usePluginRegistry.getState().commands.find((c) => c.name === cmd.toLowerCase());
if (pc) { try { pc.run(rest, arg); } catch (e) { console.error(`[plugins] /${cmd} threw`, e); } }
else client.send(cmdline.slice(1)); // raw passthrough (formatting stripped)
else { if (active === SERVER) sysLine(SERVER, `» ${cmdline.slice(1)}`, 'system'); client.send(cmdline.slice(1)); } // raw passthrough (formatting stripped)
}
}
return;